-
Notifications
You must be signed in to change notification settings - Fork 53
Change desktop font size to match google #345
Conversation
const fontSizeUrlMobile = "12px"; | ||
const fontSizeTitleDesktop = "20px"; | ||
const fontSizeTitleMobile = "28px"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this 28px
is correct. Though is later overridden, it affects the line-height calculation in the mobile snippet. Will attach screenshots.
CR 👍 A stray value of Other minor details should be updated as well. For example: the position of the down arrow icon and the line-height of the desktop description, which is slightly different. Screenshots: Desktop before – after – Google: Mobile before – after – Google (via browser dev tools) – Google (on an Android device): |
Updated the line-heights with some new constant values. Spacing between the 3 elements should now match as much as possible the new Google snippets (both mobile and desktop). Important:
Please don't forget to test the alignment of the caret icon on both mobile and desktop previews: (though it's not possible to make it perfectly vertically aligned with all the elements) |
CR 👍 |
Acceptance 👍 |
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
This PR can be tested by following these steps:
Title: 20px
URL: 16px
Meta description: 14px
Impact check
UI changes
Quality assurance
Fixes Yoast/wordpress-seo#13421