Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes classes and methods that were deprecated before version 20.8. #21362

Merged
merged 3 commits into from
May 8, 2024

Conversation

enricobattocchi
Copy link
Member

@enricobattocchi enricobattocchi commented May 2, 2024

Context

Summary

This PR can be summarized in the following changelog entry:

  • Removes classes and methods that were deprecated before version 20.8.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Just a general smoke test, since we are removing code which is not used anymore

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@enricobattocchi enricobattocchi added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label May 2, 2024
@enricobattocchi enricobattocchi changed the title Remove deprecated classes and method up to 20.7 Removes classes and methods that were deprecated before version 20.8. May 2, 2024
@thijsoo thijsoo self-assigned this May 8, 2024
Copy link
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + ACC 👍

@thijsoo thijsoo added this to the 22.8 milestone May 8, 2024
@thijsoo thijsoo merged commit 3542b3c into trunk May 8, 2024
22 checks passed
@thijsoo thijsoo deleted the remove-deprecated-up-to-20.7 branch May 8, 2024 14:10
@coveralls
Copy link

Pull Request Test Coverage Report for Build dacceccdad05ceba67f2b70eb899b477246dac1a

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 698 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 52.642%

Files with Coverage Reduction New Missed Lines %
src/generated/container.php 698 0.0%
Totals Coverage Status
Change from base Build 74678cf688db4950727dd368eaf397a1a15a4992: 0.02%
Covered Lines: 28308
Relevant Lines: 54394

💛 - Coveralls

@hardikgohil7988
Copy link

@oksanayoast @tatasha2004
For this PR I've smoke tested the Free plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants