Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aria label required to have the flexibility not to use the tooltip #21486

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented Jul 17, 2024

Context

Summary

This PR can be summarized in the following changelog entry:

  • Allow the AI button to be used without tooltip.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Create a post with content and focus keyphrase.
  • Make sure the introduction doesn't contain the focus keyphrase.
  • Make sure the SEO assessments has also the sparkle for keyphrase density and distribution.
  • Click on the sparkle button in the AI assessment fix for keyphrase in introduction.
  • Check the rest of the ai sparkle buttons are disabled and when hovering them you see no tooltip.
  • Open dev tool console and check you do not get any console error that ariaLabel prop is required.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes

@vraja-pro vraja-pro added the changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog label Jul 17, 2024
Copy link

@vraja-pro Please be aware that following packages have been abandoned and are not actively maintained anymore:

Package name Path
@yoast/babel-preset packages/babel-preset
@yoast/components packages/components
@yoast/e2e-tests packages/e2e-tests
@yoast/helpers packages/helpers
@yoast/jest-preset packages/jest-preset
@yoast/style-guide packages/style-guide

Please consider using the other packages instead.

@vraja-pro vraja-pro changed the base branch from release/23.2 to trunk July 17, 2024 14:24
@vraja-pro vraja-pro changed the base branch from trunk to release/23.2 July 17, 2024 14:25
@vraja-pro vraja-pro changed the title With no aria label required we have the flexibility not to use the tooltip Remove aria label required to have the flexibility not to use the tooltip Jul 17, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 705999af5d61801c4c3617040870823aca48d7c4

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 48.696%

Totals Coverage Status
Change from base Build 8fb173ff8ff2ae2dd79ba06711e9f5fc2e9db948: 0.0%
Covered Lines: 25253
Relevant Lines: 53697

💛 - Coveralls

@mhkuu mhkuu added changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog and removed changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog labels Jul 18, 2024
@mhkuu
Copy link
Contributor

mhkuu commented Jul 18, 2024

LGTM! 🎉

@mhkuu mhkuu merged commit e6922ef into release/23.2 Jul 18, 2024
17 checks passed
@mhkuu mhkuu deleted the remove-required-for-aria-label branch July 18, 2024 08:01
@mhkuu mhkuu added this to the 23.2 milestone Jul 18, 2024
@mhkuu mhkuu added the innovation Innovative issue. Relating to performance, memory or data-flow. label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation Innovative issue. Relating to performance, memory or data-flow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants