Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalizes the UI for Yoast AI Optimize #21501

Merged
merged 9 commits into from
Jul 30, 2024
Merged

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented Jul 24, 2024

Context

  • We want to finalize the UI for Yoast AI Optimize.

Summary

This PR can be summarized in the following changelog entry:

  • Fixes the introduction modal copy and padding, as well as the Wistia video ID.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Yoast AI Generate

  • Edit a post and click on "Use AI" button and check the following changes in the modal:
  • Check the title marked in the screenshot is the same and that space under the close button from the edge is smaller.
    Screenshot 2024-07-25 at 10 30 27
  • Confirm that the video shows the introduction video for Yoast AI Generate.

Yoast AI Optimize

  • Go to Premium SEO analysis and click on a sparkle button next to an assessment.
  • You should see the introduction modal, check the space under the close button is the same as above, also inspect he modal and check the padding matched the screenshot:
    Screenshot 2024-07-25 at 09 29 26
  • Confirm that the video shows the introduction video for Yoast AI Optimize.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes AI fixes: UX check
Fixes [Minor] 23.2 - Update text on introduction modal

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jul 24, 2024
@coveralls
Copy link

coveralls commented Jul 25, 2024

Pull Request Test Coverage Report for Build 444f4a3d16c537484fb0f38562c5033c2ed3e5fb

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4444 unchanged lines in 145 files lost coverage.
  • Overall coverage decreased (-5.4%) to 48.698%

Files with Coverage Reduction New Missed Lines %
admin/class-option-tabs-formatter.php 1 0.0%
packages/js/src/redux/reducers/preferences.js 1 0.0%
src/actions/configuration/first-time-configuration-action.php 1 91.84%
src/builders/indexable-home-page-builder.php 1 98.0%
src/builders/indexable-term-builder.php 1 99.15%
src/context/meta-tags-context.php 1 28.29%
src/editors/framework/site/post-site-information.php 1 93.88%
src/generators/breadcrumbs-generator.php 1 64.23%
src/generators/schema/webpage.php 1 90.32%
src/integrations/blocks/structured-data-blocks.php 1 16.0%
Totals Coverage Status
Change from base Build bf059a6a0be2b2af74fb1d5fe96ca8bb1f763951: -5.4%
Covered Lines: 25256
Relevant Lines: 53699

💛 - Coveralls

@mhkuu mhkuu changed the title fix padding for introduction modal Finalizes the UI for Yoast AI Optimize Jul 29, 2024
@mhkuu mhkuu added this to the 23.2 milestone Jul 29, 2024
@mhkuu
Copy link
Contributor

mhkuu commented Jul 29, 2024

Good to go! 🚀

@mykola mykola merged commit f05e8c7 into release/23.2 Jul 30, 2024
16 checks passed
@mykola mykola deleted the 1711-ai-fixes-ux-check branch July 30, 2024 07:34
@mhkuu mhkuu added the innovation Innovative issue. Relating to performance, memory or data-flow. label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation Innovative issue. Relating to performance, memory or data-flow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants