Excludes image captions inside classic blocks from the keyphrase in introduction assessment

[FAMarfuaty]

Context

• With this PR: Excludes image captions from keyphrase in introduction assessment #21414 we excluded the image captions from the keyphrase in introduction assessment for all editors. However, the solution still doesn't exclude the image caption inside a classic block in Block editor. This PR is to fix that issue.

Summary

This PR can be summarized in the following changelog entry:

• Fixes a bug where an image caption inside a classic block would be considered the introduction when using the keyphrase in introduction assessment in the default editor.
• [yoastseo enhancement] Excludes the image caption inside a classic block from the keyphrase in introduction assessment.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

AI Optimize

• Test together with this accompanying PR in Premium: https://github.com/Yoast/wordpress-seo-premium/pull/4470

Block editor, classic block

• Create a post in Block editor
• Set a keyphrase
• Add one classic block
• To the classic block, add a text with more than 300 words, make sure to add the keyphrase in the first paragraph and don't add the keyphrase anywhere else
• Go to the keyphrase in introduction assessment
• Confirm that the assessment returns with 🟢 green feedback
• Go to the keyphrase density assessment
• Confirm that the keyphrase density assessment recognizes one keyphrase occurrence
• Inside the classic block, before the first paragraph, add an image with a caption that doesn't include the keyphrase
• Confirm that the keyphrase in introduction assessment still returns with 🟢 green feedback
• Go to the keyphrase density assessment
• Confirm that the keyphrase density assessment still recognizes one keyphrase occurrence
• Add the keyphrase to the image caption
• Confirm that the keyphrase in introduction assessment still returns with 🟢 green feedback
• Go to the keyphrase density assessment
• Confirm that the keyphrase density assessment now recognizes two keyphrase occurrences

Classic editor

• Create a post in Classic editor
• Set a keyphrase
• Add a text with more than 300 words, make sure to add the keyphrase in the first paragraph and don't add the keyphrase anywhere else
• Go to the keyphrase in introduction assessment
• Confirm that the assessment returns with 🟢 green feedback
• Go to the keyphrase density assessment
• Confirm that the keyphrase density assessment recognizes one keyphrase occurrence
• Before the first paragraph, add an image with a caption that doesn't include the keyphrase
• Confirm that the keyphrase in introduction assessment still returns with 🟢 green feedback
• Go to the keyphrase density assessment
• Confirm that the keyphrase density assessment still recognizes one keyphrase occurrence
• Add the keyphrase to the image caption
• Confirm that the keyphrase in introduction assessment still returns with 🟢 green feedback
• Go to the keyphrase density assessment
• Confirm that the keyphrase density assessment now recognizes two keyphrase occurrences

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

• No further impact.

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/plugins-automated-testing/issues/1814

[mhkuu]

LGTM! 👍 Thanks for adding an additional unit test! 🙏

[mhkuu]

ACC: Works! 🎉