Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default to onDiscard in UnsavedChangesModal #21756

Merged

Commits on Oct 28, 2024

  1. Add default to onDiscard in UnsavedChangesModal

    While not necessarily useful without, it is easier to work with like this.
    Mostly because the useBlocker from react-router-dom has undefined for the reset and proceed functions unless actively blocking.
    We could rewrite the usage there to force not rendering this depending on the state. But that is what the isOpen is supposed to be for already.
    igorschoester committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    30f0716 View commit details
    Browse the repository at this point in the history