4475 fix related keyphrase status

[mykola]

Context

• Fix the related keyphrase status from orange to green when all the assessment results are good.

Summary

This PR can be summarized in the following changelog entry:

• [yoastseo] Fixes a bug where the related keyphrase score would still be orange even when all the assessment results were good.
• [shopify-seo] Fixes a bug where the related keyphrase score would still be orange even when all the assessment results were good.

Relevant technical choices:

• New ValidOnlyResultsScoreAggregator was added before the aggregate filter assessments without a score. A similar approach is used in ReadabilityScoreAggregator. Also score aggregator is introduced as a field for Accessor classes By default is SEOScoreAggregator and redefined for accessor were valid only results should counted.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Create a post with content (this article can be used).
• Click Add related keyphrase -> Keyphrase: insights
• Make sure that scores are green for every assessment.
• Make sure that the score of the Related keyphrase emote is happy/green (one in the header of Related keyphrase)
• Run the test in WordPress and in Shopify

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

• For solution separate a separate score aggregator was introduced that should impact only Related Keyword but please do a smoke test for Premium SEO analysis.

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes #4475

[coveralls]

Pull Request Test Coverage Report for Build 715b067bb4b8d73ce9cab66dd533378afdeee6eb

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 47 of 47 (100.0%) changed or added relevant lines in 10 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.008%) to 54.523%

---

Totals
Change from base Build 50c07b20a701a0eafca8bdf7a7e17f890ba58ecc:	-0.008%
Covered Lines:	30144
Relevant Lines:	55708

---

💛 - Coveralls

[mhkuu]

Nice work, but please do take the opportunity to refactor and reduce this code further now that we are touching it 👍

... otherwise we would need to do it anyway as part of resolving technical debt later on 😅

In terms of solving the bug, this PR solves the case for related keyphrase analysis, but specifically for the SEO analysis in collections in Shopify, we decided we would use the same aggregation strategy. So, we can add a custom score aggregator for those assessors (packages/yoastseo/src/scoring/assessors/collectionPages/seoAssessor.js and packages/yoastseo/src/scoring/assessors/collectionPages/cornerstone/seoAssessor.js) as well 👍