-
Notifications
You must be signed in to change notification settings - Fork 26
yosys: cleanup of ghdl-yosys-plugin config/envvars #67
base: main
Are you sure you want to change the base?
Conversation
Hmm, this PR didn't seem to build but it's probably just because It probably would have been good if I had managed to use |
The point is that I built it successfully on MSYS2 (both MINGW32 and MINGW64) without having to work around reading the
I now removed the diffs from upstream (which were merged into Yosys) and I left the additional patches, which I think are related to the static build. I also renamed it to |
Thanks for all your work upstream! I have to admit I haven't been the best open source citizen on that side of things... This looks close now but the GHDL synth smoke test is failing. Looks like |
84b39f7
to
412668c
Compare
There were two problems:
|
It seems that CXXFLAGS is properly set (-DYOSYS_ENABLE_GHDL is found in the logs), but the |
This is probably a bit higher priority now as your change upstream in yosys to use
I'm not sure the way I originally got this working was very methodical unfortunately... |
@edbordin I will fix this today. If I don't get it to work as clean as I'd like, I will revert to your solution but updating |
54fcf41
to
6f943c5
Compare
I'm getting close. Linux and macOS builds are working. Windows is not there yet. |
It seems that
yosys_ghdl.diff
points to a different*.link
file than the upstream: https://github.com/ghdl/ghdl-yosys-plugin/blob/master/yosys.diff. I thought thatGHDL_LDLIBS
might have been a workaround because of having overlooked that change.