Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wet-farmland #112

Open
wants to merge 2 commits into
base: 1.20
Choose a base branch
from
Open

Conversation

Pantera07
Copy link
Contributor

PaperMC/Paper#9968

There are two options: dry-farmland and wet-farmland, the reason it is separate is because the performance impact of dry farmlands isn't that big, but has a big gameplay impact where players may be confused about why the farmland isn't wet after placing water near it. Yes, dry farmlands have the same isNearWater checks as wet farmlands, but dry farmlands do end up turning to regular dirt after a while, so it is like they are "naturally" throttled by the server.

@YouHaveTrouble
Copy link
Owner

I'm not sure if this is relevant. I haven't seen any spark reports or timings suggesting that farmland updates is something that has major impact on tps. Would appreciate such reports to illustrate the issue

@Pantera07
Copy link
Contributor Author

Large farms may cause lag. farmland searches for nearby blocks every tick.

@YouHaveTrouble
Copy link
Owner

Which in my minecraft optimization career I've seen exactly 0 times. If you're able to provide a spark from a server with the situation where farmland causes tps issues, I'll merge this

@LuluxClient
Copy link

I can confirm this uses 2-3% of my ticks on huge servers
image

@YouHaveTrouble
Copy link
Owner

spark report please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants