Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set match_word to true for git_blacklist #15

Closed
wants to merge 1 commit into from

Conversation

peterjaap
Copy link

@peterjaap peterjaap commented Dec 1, 2022

To avoid triggering on add() while dd() is blacklisted. Also added exit(

See;

This option allows you to choose how the keywords is found.

For instance let's say you have a keyword looking like "dd(" by default this task would also find any
text before or after the keyword meaning this: function add($someTask) would still be considered invalid.
This configuration option allows you to get around that issue.

@Anve94
Copy link
Member

Anve94 commented Dec 8, 2022

Hi @peterjaap, thanks for raising this. Seems like we had the same idea here. I also opened #16 with the same changes. I'll incorporate your exit change on the git blacklist config there too. I'll close this one and will get #16 tagged and released soon

@Anve94 Anve94 closed this Dec 8, 2022
@peterjaap
Copy link
Author

Thanks!

@peterjaap peterjaap deleted the patch-2 branch December 8, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants