Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct clock to communicate with PMW3360 sensor #109

Merged
merged 1 commit into from
Apr 11, 2022
Merged

use correct clock to communicate with PMW3360 sensor #109

merged 1 commit into from
Apr 11, 2022

Conversation

koron
Copy link
Collaborator

@koron koron commented Apr 11, 2022

It is too fast to communicate with PMW3360DM sensor, 70MHz.
(It is PMW3360DM internal clock, is not for SPI)

PMW3360DM's datasheet recommends 2MHz for SPI.

image

QMK treats 70MHz as zero divisor and ATmega32U4 works with 4MHz.
It works but twice of the recommended speed.

This PR fix it, to use 2MHz clock to communicate with PMW3360DM.

@koron koron self-assigned this Apr 11, 2022
@Yowkees Yowkees merged commit 90252cb into Yowkees:main Apr 11, 2022
@Yowkees
Copy link
Owner

Yowkees commented Apr 11, 2022

Thank you very much for your reviewing of PMW3360's datasheet.
This chage must make Keyball much better. Thank you.

@koron koron deleted the correct-spi-clock branch May 8, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants