define TAP_CODE_DELAY for common keymaps #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
delayがはいった状態で |
mentako-ya
added a commit
to mentako-ya/mtk
that referenced
this pull request
Sep 24, 2022
mentako-ya
added a commit
to mentako-ya/mtk
that referenced
this pull request
Sep 24, 2022
matrix_mask修正 Row4 Col3 使用可能
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #110
viaとdefaultのkeymapに
TAP_CODE_DELAYを5ミリ秒にするよう設定した。キーボードのconfig.hで設定してしまうと、
ユーザーが自前のキーマップでビルドする際に混乱する
(場合によってはビルドが失敗するようになる)
ので、デフォルトのファームウェアであるviaとdefaultだけで設定するようにした。
5ミリ秒である理由は特にないが
TAP_CODE_DELAYは1以上であればコード的に有効になることまた100ミリ秒や10ミリ秒では長すぎ
1ミリ秒では短すぎると感じて5ミリ秒とした。