Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error on OLED disabled #304

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Conversation

MiSawa
Copy link
Contributor

@MiSawa MiSawa commented Aug 12, 2023

When one attempted to build the firmware with OLED feature disabled, following compile errors are thrown.

keyboards/keyball/lib/keyball/keyball.c:69:20: error: ‘format_4d’ defined but not used [-Werror=unused-function]
Compiling: keyboards/keyball/lib/keyball/keyball.c                                                  [ERRORS]
 static const char *format_4d(int8_t d) {
                    ^
keyboards/keyball/lib/keyball/keyball.c:96:13: error: ‘to_1x’ defined but not used [-Werror=unused-function]
 static char to_1x(uint8_t x) {
             ^

These two functions are used only under #ifdef OLED_ENABLE guard, and thus have to be guarded as well.

@Yowkees Yowkees requested a review from koron September 14, 2023 23:50
@koron
Copy link
Collaborator

koron commented Sep 16, 2023

I'll check and merge this after upgrading QMK 0.22.

Thank you!

@koron koron self-assigned this Sep 16, 2023
@koron koron merged commit d873e32 into Yowkees:main Sep 16, 2023
@koron
Copy link
Collaborator

koron commented Sep 16, 2023

confirmed on local.

@MiSawa MiSawa deleted the fix/no-oled branch September 16, 2023 07:22
koron added a commit to koron/qmk_firmware that referenced this pull request Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants