Print (up to 3) pressing keys on OLED #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Printing pressing 3 keys is great idea! I would like to hear about this from keyball firmware developers. |
|
Looks great idea. I'll merge this with some changes. |
|
I'll merge and refine with #506 |
|
This is merged with #506. Thank you for the suggestion |
koron
added a commit
to koron/qmk_firmware
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It replaces the last section of the "Key" row on OLED with printing currently pressing (aka. not released) keys up to 3 keys. It shows the key state reactively. This kind of reactivity would allow us to easily diagnose misfunctioned behavior.
The reason I chose the section for placing this is that, ultimately, it does not provide additional information than the keycode section.
A huge downside is that it increases the firmware size as 128 bytes (in my build environment).
27628/28672 (96%, 1044 bytes free)to
27756/28672 (96%, 916 bytes free)D5D64CF5-79C2-4FF6-A9CA-316E0F6314E7-2708-0000019AB895677E.mov