Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update SPLIT_HAND_MATRIX_GRID left/right logic to be compatible with qmk 0.24 #496

Closed
wants to merge 1 commit into from
Closed

update SPLIT_HAND_MATRIX_GRID left/right logic to be compatible with qmk 0.24 #496

wants to merge 1 commit into from

Conversation

zhyu
Copy link

@zhyu zhyu commented Mar 4, 2024

fix #495

@koron
Copy link
Collaborator

koron commented Mar 21, 2024

This is not needed for QMK 0.22.3 which Keyball using.

So I will delay merging this PR until Keyball switches to QMK 0.24 or higher.

@koron
Copy link
Collaborator

koron commented Mar 21, 2024

Or could you please explain your motivation for switching to QMK 0.24 or later?

@koron koron added the wontfix This will not be worked on label Mar 21, 2024
@koron koron closed this Mar 24, 2024
@koron
Copy link
Collaborator

koron commented Mar 27, 2024

I'll merge this when Keyball upgrade QMK 0.24 or later.

Thank you.

ld50themetaler added a commit to ld50themetaler/keyball that referenced this pull request Mar 27, 2024
@ld50themetaler
fix: PR Yowkees#496 を参考に修正
09c53a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect handedness since qmk 0.24.0
2 participants
@zhyu @koron