Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New scroll snap methods and hooks to full customization #560

Merged
merged 6 commits into from
Apr 16, 2024

Conversation

koron
Copy link
Collaborator

@koron koron commented Apr 15, 2024

See alsor #559 and #555

  • Three scroll snap mode, be switched manually

    • New three keycodes
      • SSNP_VRT vertical scroll snap mode (default)
      • SSNP_HOR horizontal scroll snap mode
      • SSNP_FRE free scroll mode
    • Can be persisted to EEPROM with KBC_SAVE
    • Current mode is displayed on OLED; VT, HO, SCR
  • Can revert to previous behavior up to 1.3.2

    • Add #define KEYBALL_SCROLLSNAP_ENABLE 1 to your config.h
  • New overridable functions

    • How trackball movement is applied to mouse movement
    • How trackball movement is applied to mouse scroll
  • Removed a set of keycodes for directly changing RGBLIGHT modes from Keyball39 and 46 keymaps

    This is to register the SSNP_* keycodes.
    Please use RGB_MOD and RGB_RMOD instead of those.

TODO:

  • documents
  • comments
  • indicate current scroll snap mode
  • add keycodes to keymap
  • more documents

@koron koron mentioned this pull request Apr 15, 2024
@koron koron force-pushed the scroll-snap-method-559 branch from 9d4d4c5 to 409d474 Compare April 15, 2024 15:47
koron added 2 commits April 16, 2024 02:27
"SCR" in OLED will be changed to "VT", or "HO" depending on scroll snap mode.
@koron koron force-pushed the scroll-snap-method-559 branch from 753f0e3 to b9c499a Compare April 16, 2024 02:35
@koron
Copy link
Collaborator Author

koron commented Apr 16, 2024

Differences in firmware size due to this change

name before after diff oversized
keyball_keyball39_test.hex 22,730 22,730 +0
keyball_keyball39_default.hex 27,396 27,382 -14
keyball_keyball39_via.hex 27,158 27,138 -20
keyball_keyball44_test.hex 22,724 22,724 +0
keyball_keyball44_default.hex 27,390 27,376 -14
keyball_keyball44_via.hex 27,152 27,132 -20
keyball_keyball46_test.hex 22,686 22,686 +0
keyball_keyball46_default.hex 27,352 27,338 -14
keyball_keyball46_via.hex 27,086 27,066 -20
keyball_keyball46_test_Left.hex 22,686 22,686 +0
keyball_keyball46_test_Both.hex 22,686 22,686 +0
keyball_keyball46_via_Left.hex 27,086 27,066 -20
keyball_keyball46_via_Both.hex 27,086 27,066 -20
keyball_keyball61_test.hex 22,850 22,850 +0
keyball_keyball61_default.hex 27,716 27,702 -14
keyball_keyball61_via.hex 27,476 27,468 -8
keyball_one47_test.hex 18,958 18,954 -4
keyball_one47_default.hex 21,758 21,754 -4
keyball_one47_via.hex 24,548 24,544 -4
avg(diff)
-9.26316

@koron koron marked this pull request as ready for review April 16, 2024 06:03
@koron koron merged commit b0cde71 into Yowkees:main Apr 16, 2024
20 checks passed
@koron koron deleted the scroll-snap-method-559 branch April 16, 2024 06:34
Code-Hex added a commit to Code-Hex/ble-micro-pro-keyball61 that referenced this pull request May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant