Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix image names #571

Merged
merged 2 commits into from
Jun 20, 2024
Merged

fix image names #571

merged 2 commits into from
Jun 20, 2024

Conversation

spaette
Copy link
Contributor

@spaette spaette commented Dec 27, 2023

fix typos in bitmap image file names

Copy link
Contributor

@csalas-yubico csalas-yubico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are breaking changes due to file name changes - see my comments for the issues found

@spaette spaette marked this pull request as draft June 12, 2024 16:05
@spaette spaette marked this pull request as ready for review June 12, 2024 18:15
@spaette
Copy link
Contributor Author

spaette commented Jun 15, 2024

I presume rebasing is unnecessary.

Copy link
Contributor

@csalas-yubico csalas-yubico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good - regarding your previous comments, I don't believe a rebase is necessary

@elukewalker elukewalker merged commit ac8f977 into Yubico:master Jun 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants