Remove large binaries from the deployed container #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcalderon
approved these changes
Mar 25, 2024
ajhall
force-pushed
the
separate-releases
branch
from
87182d7
to
949e35e
Compare
ajhall
changed the title
ajhall
force-pushed
the
separate-releases
branch
2 times, most recently
from
b2dd486
to
949e35e
Compare
ajhall
force-pushed
the
separate-releases
branch
from
949e35e
to
3373457
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on https://github.com/Yubico/yubico-binaries/pull/144
The developers.yubico.com site builds into a huge Docker image that contains about 15 GB of binaries. This causes some issues in our Kubernetes clusters and generally just isn't a good use of resources, so we'd like to shrink the container image.
https://yubico.atlassian.net/browse/INFRA-5045
Fastly has been configured to route requests directly to a GCS bucket instead of from the
developerspod.https://github.com/Yubico/infra-fastly/pull/166
That means that we don't need the binaries in this container anymore. The https://github.com/Yubico/yubico-binaries repo is still cloned during the build process, but the Git LFS objects aren't fetched. The LFS pointer files are used as placeholders so the release page generation scripts will still work the same as before.