Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change URL for LibreSSL dependency to avoid issues with the windows build #766

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

bobomb
Copy link
Contributor

@bobomb bobomb commented Dec 29, 2023

Seems like the powershell Invoke-WebRequest command to download LibreSSL is failing - I suspect the URL being used is being blocked, as the URL works fine when opened from a browser, but does not when using Invoke-WebRequest.

I was able to workaround this by changing the URL in windows\const.ps1 from https://cloudflare.cdn.openbsd.org/pub/OpenBSD/LibreSSL to https://ftp.openbsd.org/pub/OpenBSD/LibreSSL/, which works with Invoke-WebRequest

@LDVG
Copy link
Contributor

LDVG commented Jan 2, 2024

Hi,

Thanks for the report. What version of Windows are you running? Does the alternate patch below help?

diff --git a/windows/build.ps1 b/windows/build.ps1
index 5ac045b3..c15f315d 100644
--- a/windows/build.ps1
+++ b/windows/build.ps1
@@ -17,6 +17,7 @@ param(
 
 $ErrorActionPreference = "Stop"
 [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12
+[Net.ServicePointManager]::SecurityProtocol += [Net.SecurityProtocolType]::Tls13
 
 . "$PSScriptRoot\const.ps1"
 

(We might have to change mirror regardless to accommodate our supported Windows versions. Just want to understand this issue.)

@bobomb
Copy link
Contributor Author

bobomb commented Jan 2, 2024

Hi @LDVG
The above patch did not work, the error is the same. I am on Windows 10 21H2 (10.0.19044).

Windows 10 does not support TLS 1.3 and the Cloudflare mirror only
offers TLS 1.3. To remedy, revert to the canonical release directory.
@LDVG LDVG force-pushed the wip/bobomb/fix-windows-build branch from 367daa9 to d1cca1b Compare January 2, 2024 15:59
@LDVG
Copy link
Contributor

LDVG commented Jan 2, 2024

It'd appear Windows 10 does not support TLS 1.3, and the Cloudflare mirror only offers TLS 1.3 (as tested via openssl s_client). The alternate patch above does work fine on Windows 11 and Windows Server 2022.

I have slightly reworded your patch to reflect this and shortened the commit title, but its contents remain the same (barring the removal of the extra trailing forward slash). If this problem bubbles up again sometime we might have to try a different approach. :-)

Thank you!

@LDVG LDVG requested a review from kongeo January 2, 2024 16:02
@bobomb bobomb closed this Jan 2, 2024
@bobomb bobomb reopened this Jan 2, 2024
@bobomb
Copy link
Contributor Author

bobomb commented Jan 2, 2024

Whoops, didn't mean to accidently close this PR.

@kongeo kongeo merged commit d5f4989 into Yubico:main Jan 3, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants