Add auto trim for videos from device library using trimmerMaxDuration

[mendesbarreto]

This commits adds the request from issue #341.

This case occurs when the user already has a video selected and enables a multiselection to pick more than one type of media (video or image), so, the trimmer step becomes optional.

[Ludotrico]

Has this feature been implemented? It is crucial functionality. @mendesbarreto @heitara

[heitara]

It would be best if all the white-spaces are not changed, because this will reduce the diff file massively.

[mendesbarreto]

It would be best if all the white-spaces are not changed because this will reduce the diff file massively.

About that, When I push some commit to GitHub I have a script which runs automatically some swiftlint rules like white spaces. I will try to remove what it has done.

[mendesbarreto]

It would be best if all the white-spaces are not changed because this will reduce the diff file massively.

@heitara I tried to remove all the changes Swiftlint did on the code, I tried my best but how the project does not have any spacing pattern, some times the lines have space other not, it makes hard to guess, after my last commit.

But It's done =) . If you want the next pull request we can put Swiftlint and you can define what kind of rules you like or not on the project, it will simply the contribution workflow and avoid this kind of problem and of course, this will increase the cohesion of your codebase.

Thx

[heitara]

Completely agree. Code style refactoring should be done in separate commit without any functionality change.

[Ludotrico]

I am new to the concept of pull requests. Will there be some sort of notification when this branch is merged into the master? Will cocoa pods automatically add the new code to an existing Xcode project?
@heitara @mendesbarreto

[mendesbarreto]

I am new to the concept of pull requests. Will there be some sort of notification when this branch is merged into the master? Will cocoa pods automatically add the new code to an existing Xcode project?
@heitara @mendesbarreto

Hello @Ludotrico, To receive a notification when a new version is available you can go to "Watch" option at the header of the site and choose the option "release only" or to receive all notification you can choose the option "Watching"

[Ludotrico]

Thanks, just did that.
Will cocoa pods automatically add the newly merged code to an existing Xcode project?
@mendesbarreto

[mendesbarreto]

Thanks, just did that.
Will cocoa pods automatically add the newly merged code to an existing Xcode project?
@mendesbarreto

@Ludotrico it will depend on how you wrote this dependency in your file, I believe the next pod version will be v4.3.0, so, if you wrote like this:

pod 'YPImagePicker' 
#OR
pod 'YPImagePicker' ~> 4.2

The next time you run pod update the lib will be updated

[Ludotrico]

Thank you for the clarification, now what is the procedure to get it merged? I see that NikKovlos has approved it, how many more approvals does it require? Who can approve it?
@mendesbarreto

[mendesbarreto]

Hello Guys,

I can't merge because I don't have any write access to the repo:

Thx you all.

[NikKovIos]

@s4cha must approve it too

[s4cha]

Great work 🤩

[Ludotrico]

atta boy @mendesbarreto