-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data folder should be in yunohost.app #15
Comments
I think this issue is also related to the "music" folder of #16 |
YunoHost also has per-user and shared media storage which should be integrated. |
@EliotBerriot can we have one folder per user so we can enable this? https://docs.funkwhale.audio/configuration.html#music-directory-path |
Do you mean per-funkwhale user? No, it's not possible because uploaded files won't be binded to only one user anymore in the next releases, when we have deduplication in place (the same file may be uploaded by X user, but will only be stored once) |
But we have a media folder in yunohost that have songs folder which is shared to all the users. User can put the songs in this folder from nextcloud and it is shared to with all other users. |
There is no backup of media for upgrade.
I don't see the point of multimedia for handling funkwhale's media.
So, the last use case is to provide an easy way to import files? Correct?
--
Jean-Baptiste Holcroft
|
It's more standard for YunoHost applications. And being able to easily manage/download the files themselves is quite useful. Personally being able to use my existing Nextcloud setup to sync my music into the media folder, both to and from Funkwhale, would be very useful. |
OK then. I'll close this request.
Ynh is for casual users and not about advanced use cases as you describe it.
Let's keep thing simple.
If you need easy download, ask the feature upstream.
If you want fast upload and you have a slow connexion, host your server on your network. If you have a fast bandwidth, it won't change anything.
|
Hello,
I would love to keep things as simple as possible. Thanks a lot |
As said by @anmol26s, YunoHost provides a media folder, Helpers are available to use this directory painlessly. |
For a temporary fix, moving the folder in |
cc @EliotBerriot I think we need help please 🙏 |
Hi @ImaCrea, I'm not sure how I can help here. The directory for uploaded files can already be customized on Funkwhale's side (via the As I'm not a YunoHost user, developper or packager, I cannot work on this myself. Of course, I'm here to help if the person implementing this need advice regarding those variables and their use, reviewing, feedback, or anything else where my input could be useful :) |
Thank you for your dear help @EliotBerriot :) @Jibec does Eliot's answer help you? |
I guess I'll do the change, too many people argue about it.
Only time is an issue.
PR are welcome.
Otherwise, it will probably take some time, because I have very few time for contribution. I'm fine with letting the project to a new maintainer if someone is willing to.
|
I wish I could but I'm afraid I'm lacking some tech knowledge atm to carry it :/
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
…On Sunday 8 September 2019 14:36, Jean-Baptiste ***@***.***> wrote:
I guess I'll do the change, too many people argue about it.
Only time is an issue.
PR are welcome.
Otherwise, it will probably take some time, because I have very few time for contribution. I'm fine with letting the project to a new maintainer if someone is willing to.
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#15?email_source=notifications&email_token=AAF2TLEU2X2AS5M3GSJYQBTQITWUFA5CNFSM4FFVF4VKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6FO36A#issuecomment-529198584), or [mute the thread](https://github.com/notifications/unsubscribe-auth/AAF2TLBNFP5TURVH4HZX76DQITWUFANCNFSM4FFVF4VA).
|
My thoughts on this are as follows, based on this thread (I welcome feedback. I'm very new to Yunohost): New InstallationsNew installations should have their directory set to Existing InstallationsExisting installs will be trickier given that people may have set their servers up differently, but I would guess that the people who have manually changed their setup will be comfortable with making changes to match this repository. If we're working with the assumption that people generally leave these files in
The problem with this approach is that Funkwhale uses the
This second approach is more long-winded, but it is a bit more robust as far as I can tell for ensuring that we don't bork existing installations since it will work for both locations. As I say, I welcome feedback. I'm still learning the ropes here, so it would be good to get an idea of how others would go about this. I'm also curious about what expectations are with regards to deinstallation. Should files remain where they are? |
Can I reproduce this on a fresh installation of Funkwhale? Do I just change the env var 'MEDIA_ROOT=' to '`/home/yunohost.multimedia/share/funkwhale/' and it will just work, or do I need to do an in place import? |
* Testing (#130) * Uprade to 1.1 and fixes Twisted by retrograding it (#129) * Apply example_ynh Fix #15 * Fix services * Fix several merging * Stick to official install process * fix path_transversal * Using option '--log_type systemd' with 'yunohost service add' is not relevant anymore * Try to fix package_check * Fix package_check test * Update check_process * Trying to fix package_check * Update env.prod * remove sleep * Better service name * missing datadir * line 111: upgrade_type: unbound variable * Implement --is_big * Fix stopping service from previous version * Fix upgrade * Fix upgrade * Apply example_ynh * Apply example_ynh * Fix rights * Update api.src * Update env.prod * Update front.src * Update manifest.json * Update README.md * Update README_fr.md * Fix chmod * Fix rights Co-authored-by: Thomas <51749973+Thovi98@users.noreply.github.com> Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com>
* Update README.md * Test bump to 1.0 * Bump to Yunohost 4 (for Debian upgrade) * Test removal of nonexistent scripts * Correct Typo * Update README.md * Fix linter warnings * Fix linter * Fix linter warnings * Cleaning up * Update README.md * Update to 1.0.1 (#119) * Update to 1.0.1 * Set new permissions * Add French Readme * Readme update * Update README.md * Update README.md * Update README_fr.md * Update README.md Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> * Update README_fr.md Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> * Update README.md Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> * Update README_fr.md Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> * Finding an available port * Uprade to 1.1 and fixes Twisted by retrograding it (#129) * Fix linter warning : no need to use $is_public * Clarify custom paths needed to import collections of music files in Readme. (#134) * Update readme to indicate custom import path Yunohost installations of Funkwhale use a different path for file imports than those indicated in the Funkwhale documentation.. (/var/www/Funkwhale/import). We should therefore indicate to the admin user what that path is, and steps necessary to use it. Addresses #132. * Fix bash highlighting. * Update README.md Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> * Apply Example_ynh (#131) * Testing (#130) * Uprade to 1.1 and fixes Twisted by retrograding it (#129) * Apply example_ynh Fix #15 * Fix services * Fix several merging * Stick to official install process * fix path_transversal * Using option '--log_type systemd' with 'yunohost service add' is not relevant anymore * Try to fix package_check * Fix package_check test * Update check_process * Trying to fix package_check * Update env.prod * remove sleep * Better service name * missing datadir * line 111: upgrade_type: unbound variable * Implement --is_big * Fix stopping service from previous version * Fix upgrade * Fix upgrade * Apply example_ynh * Apply example_ynh * Fix rights * Update api.src * Update env.prod * Update front.src * Update manifest.json * Update README.md * Update README_fr.md * Fix chmod * Fix rights Co-authored-by: Thomas <51749973+Thovi98@users.noreply.github.com> Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> * Update conf/nginx.conf Co-authored-by: Thomas <51749973+Thovi98@users.noreply.github.com> * Update conf/nginx.conf Co-authored-by: Thomas <51749973+Thovi98@users.noreply.github.com> * fix * Fix rights for datadir from previous version * Update upgrade * Fix recursive chmod * Fix import link * Update README_fr.md Co-authored-by: Thomas <51749973+Thovi98@users.noreply.github.com> Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> Co-authored-by: Alexandre Aubin <alex.aubin@mailoo.org> Co-authored-by: Ciarán Ainsworth <cda@rootkey.co.uk> Co-authored-by: Ciarán Ainsworth <ciaranainsworth@posteo.net> Co-authored-by: ericgaspar <junk.eg@free.fr> Co-authored-by: Thomas <51749973+Thovi98@users.noreply.github.com> Co-authored-by: Amos Blanton <lightnin@users.noreply.github.com>
* Upgrade to 1.1.1 (#138) * Update README.md * Test bump to 1.0 * Bump to Yunohost 4 (for Debian upgrade) * Test removal of nonexistent scripts * Correct Typo * Update README.md * Fix linter warnings * Fix linter * Fix linter warnings * Cleaning up * Update README.md * Update to 1.0.1 (#119) * Update to 1.0.1 * Set new permissions * Add French Readme * Readme update * Update README.md * Update README.md * Update README_fr.md * Update README.md Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> * Update README_fr.md Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> * Update README.md Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> * Update README_fr.md Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> * Finding an available port * Uprade to 1.1 and fixes Twisted by retrograding it (#129) * Fix linter warning : no need to use $is_public * Clarify custom paths needed to import collections of music files in Readme. (#134) * Update readme to indicate custom import path Yunohost installations of Funkwhale use a different path for file imports than those indicated in the Funkwhale documentation.. (/var/www/Funkwhale/import). We should therefore indicate to the admin user what that path is, and steps necessary to use it. Addresses #132. * Fix bash highlighting. * Update README.md Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> * Apply Example_ynh (#131) * Testing (#130) * Uprade to 1.1 and fixes Twisted by retrograding it (#129) * Apply example_ynh Fix #15 * Fix services * Fix several merging * Stick to official install process * fix path_transversal * Using option '--log_type systemd' with 'yunohost service add' is not relevant anymore * Try to fix package_check * Fix package_check test * Update check_process * Trying to fix package_check * Update env.prod * remove sleep * Better service name * missing datadir * line 111: upgrade_type: unbound variable * Implement --is_big * Fix stopping service from previous version * Fix upgrade * Fix upgrade * Apply example_ynh * Apply example_ynh * Fix rights * Update api.src * Update env.prod * Update front.src * Update manifest.json * Update README.md * Update README_fr.md * Fix chmod * Fix rights Co-authored-by: Thomas <51749973+Thovi98@users.noreply.github.com> Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> * Update conf/nginx.conf Co-authored-by: Thomas <51749973+Thovi98@users.noreply.github.com> * Update conf/nginx.conf Co-authored-by: Thomas <51749973+Thovi98@users.noreply.github.com> * fix * Fix rights for datadir from previous version * Update upgrade * Fix recursive chmod * Fix import link * Update README_fr.md Co-authored-by: Thomas <51749973+Thovi98@users.noreply.github.com> Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> Co-authored-by: Alexandre Aubin <alex.aubin@mailoo.org> Co-authored-by: Ciarán Ainsworth <cda@rootkey.co.uk> Co-authored-by: Ciarán Ainsworth <ciaranainsworth@posteo.net> Co-authored-by: ericgaspar <junk.eg@free.fr> Co-authored-by: Thomas <51749973+Thovi98@users.noreply.github.com> Co-authored-by: Amos Blanton <lightnin@users.noreply.github.com> * remove others_var * no more needed Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com> Co-authored-by: Alexandre Aubin <alex.aubin@mailoo.org> Co-authored-by: Ciarán Ainsworth <cda@rootkey.co.uk> Co-authored-by: Ciarán Ainsworth <ciaranainsworth@posteo.net> Co-authored-by: ericgaspar <junk.eg@free.fr> Co-authored-by: Thomas <51749973+Thovi98@users.noreply.github.com> Co-authored-by: Amos Blanton <lightnin@users.noreply.github.com>
The data folder should be in /home/yunohost.app/funkwhale/data because sometimes the media can take lot of space fill up the limited space in /var. /home folder is generally reserved with lot of space to keep all the media. Further its good idea to keep media away from the app core files.
I have faced this issue in Peertube too.
See here YunoHost-Apps/peertube_ynh#8
The text was updated successfully, but these errors were encountered: