Develop NOT for production #26

Shnoulle · 2017-02-20T15:26:33Z

There are some difference between same domain and other domain

Other domain : webserver are broken : because SSOWat don't redirect to the good domain (this domain don't have /yunohost currently) ynh bug or this install bug ?
Then activate LDAP for user 1 seems OK , but Other domain : unable to use primary user #25 broken (LS bug ? mis-feature ?)

=> Currently user 1 must not be a ynh user : solution create a fake one : done here

- Fix YunoHost-Apps#17 - Here get a specific commit (specific command action for plugin)

[fix] partially YunoHost-Apps#25 using an alt user for super-super-admin [dev] Add a activatePlugin (to manage ls via a ynh plugin (when i done it) [dev] Little fix on installer (warning when testing files in patch directory) [dev] Using LimeSurvey install command for installing

Shnoulle · 2017-02-20T15:27:21Z

conf/config.php.j2

@@ -56,7 +56,12 @@ return array(
        // LimeSurvey developers: Set this to 2 to additionally display STRICT PHP error messages and get full access to standard templates
                'debug'=>0,
                'debugsql'=>0, // Set this to 1 to enanble sql logging, only active when debug = 2
-				'enableLdap'=>true
+                /* yunohost part */
+                'auth_webserver_user_map' => array( '{{ admin }}'=>'ynh_admin'),// Primary user as ynh admin


admin choosen when installing : super-super admin via webserver only #25

Why do we need to call this user ynh_admin (and not {{ admin }} ) ?

I do some test : if you remove user access (1st user) from LS : then you don't have a user who can set super-admin ...

The issue with LS is

Only the 1st super-admin (userid==1) can set other super-admin

The 1st super-admin (userid==1) can always log by DBAuth

The 1st super admin can not be removed (from LS)

The 1st super-admin have always all the rights on all ...

Then : if you set 'ynh-user1' to super-admin at start, play a little, via yunohots : remove this admin, set other admin : the new admin don't are really a real super-admin ....

It's really the point where i didn't know how it's best to fix ....

Shnoulle · 2017-02-20T15:27:31Z

conf/config.php.j2

-				'enableLdap'=>true
+                /* yunohost part */
+                'auth_webserver_user_map' => array( '{{ admin }}'=>'ynh_admin'),// Primary user as ynh admin
+                'auth_webserver_autocreate_user'=>1,


Shnoulle · 2017-02-20T15:28:08Z

conf/data.sql.j2

 (2,'AuditLog',0),
 (3,'oldUrlCompat',0),
 (4,'ExportR',0),
 (5,'Authwebserver',1),
 (6,'extendedStartPage',0),
 (7,'ExportSTATAxml',0),
 (8,'QuickMenu',0),
-(9,'AuthLDAP',0);
+(9,'AuthLDAP',1);


Fix 'another domain' or AuthWebserver not default with another domain (allow ldap)

OK, I need to test. If I remember, with AuthLDAP the user is obliged to login twice no ?

Yes, but there are some issue with Auth webserver if LS are not a subdirectory of ynh primary server. Last time i test it ....

Shnoulle · 2017-02-20T15:28:38Z

manifest.json

@@ -2,7 +2,7 @@
    "name": "LimeSurvey",
    "id": "limesurvey",
    "packaging_format": 1,
-    "version": "2.62.2",
+    "version": "2.62.2.1",


I wait for 2.62.3 for final release : false version

Shnoulle · 2017-02-20T15:29:46Z

patches/app-0002-301de6e.patch

+ update
+
+---
+ application/commands/ActivatePluginCommand.php | 70 ++++++++++++++++++++++++++


To move DB direct access system to ls system (with a new ynh plugin (i work on it). Think we can manage really more easily ls via ynh after.

Shnoulle · 2017-02-20T15:30:55Z

scripts/_common.sh

    sudo mkdir -p "$DEST"
-    sudo chown $AS_USER: "$DEST" 
+    sudo chown $AS_USER: "$DEST"
    if [ "$(echo ${SOURCE_FILE##*.})" == "gz" ]; then
        ynh_exec_as "$AS_USER" tar xf $SOURCE_FILE -C "$DEST" --strip-components 1
    elif [ "$(echo ${SOURCE_FILE##*.})" == "bz2" ]; then
        ynh_exec_as "$AS_USER" tar xjf $SOURCE_FILE -C "$DEST" --strip-components 1
    elif [ "$(echo ${SOURCE_FILE##*.})" == "zip" ]; then
        mkdir -p "/tmp/$SOURCE_FILE"
        ynh_exec_as "$AS_USER" unzip -q $SOURCE_FILE -d "/tmp/$SOURCE_FILE"


I try with zip : but seems there are an issue here : user don't have the right on /tmp/$SOURCE_FILE not ls related and not really needed

Shnoulle · 2017-02-20T15:31:30Z

scripts/_common.sh

    # Apply patches
-    if [ -f ${PKG_DIR}/patches/$SOURCE_ID-*.patch  ]; then


Before : have an error shown here, now allow multiple patch file without bad sentence in command

Shnoulle · 2017-04-01T09:16:24Z

@zamentur que pense tu des modifications ici ? Est ce que je continu dans ce sens sur l'utilisateur numéro 1 ou bien est ce que je revient sur le principe que l'utilisateur 1 reste celui de ynh.

En fait : ici c'est la mise à jour que j'aurais plus de mal à gérer.

Denis

zamentur

Thanks, this pr is cool !
The upgrade script is missing, but we can wrote it later.
I need to test the LDAP part.

zamentur · 2017-04-01T11:06:13Z

scripts/install

 # Set permissions
 ynh_set_default_perm $local_path
 sudo chmod -R u+w $local_path/tmp
 sudo chmod -R u+w $local_path/upload
-sudo chmod -R u+w $local_path/application/config/
+#~ sudo chmod -R u+w $local_path/application/config/


Without write options the ynh_admin can't change the configuration of LS.
What was the idea to remove this ?

Oups, unsure , maybe a bad removing during testing ... but have another idea here : allow to load user-config from another file (in user directory). Must be reviewed.

zamentur · 2017-04-01T11:07:39Z

scripts/install


 sudo yunohost app addaccess $app -u $admin
-ynh_sso_access "/index.php?r=admin,/index.php?r=plugins,/scripts"


I don't remember why I have put a protection on /index.php?r=plugins,/scripts
May be it's historical (with the last version of the package)

/script : really not needed, about plugins : specific : ls have issue here (plugins/index) but some plugin must allow public access to plugins/

zamentur · 2017-04-01T11:13:16Z

conf/data.sql.j2

 (2,'AuditLog',0),
 (3,'oldUrlCompat',0),
 (4,'ExportR',0),
 (5,'Authwebserver',1),
 (6,'extendedStartPage',0),
 (7,'ExportSTATAxml',0),
 (8,'QuickMenu',0),
-(9,'AuthLDAP',0);
+(9,'AuthLDAP',1);


OK, I need to test. If I remember, with AuthLDAP the user is obliged to login twice no ?

zamentur · 2017-04-01T12:20:09Z

tested, works well.
Configuration seems to be updatable.

About ynh_admin, I don't know I am not sure to understand why it's needed, but you have a better knowledge on LS than me.
I think it could be strange for a user to connect with his username and see "ynh_admin" as the user connected !

Shnoulle · 2017-04-01T15:48:53Z

Yes : ynh_admin are really the issue here .....

2 options :

The first admin set :
- disallow remove rights via ynh (must be fixed)
Use a false admin (like here)
- can be updated in ynh part.

It's the choice, i can do 2, but not sure for 1 (know less ynh than LS ).

And see : #25 the super-super-admin can not come from LDAP .....

Shnoulle · 2017-04-29T15:55:15Z

PS : i think i improve LS to allow multiple super-super-admin ;)

Shnoulle · 2017-06-03T08:44:06Z

I think it could be strange for a user to connect with his username and see "ynh_admin" as the user connected !

After more thinking : you're right . Best seems to have a dedicated user for 1st admin (else you can break system if you remove the rights of the first user (tested with old ynh).

I review next week, update to last version, make a multiple download system for other needed plugins .

Shnoulle · 2017-06-19T08:24:00Z

Must review all :(

Shnoulle and others added 3 commits February 18, 2017 20:10

[fix] Use github link for source file

d065dbb

- Fix YunoHost-Apps#17 - Here get a specific commit (specific command action for plugin)

[dev][fix] Add the patchs :whistle:

d574e83

Shnoulle commented Feb 20, 2017

View reviewed changes

zamentur reviewed Apr 1, 2017

View reviewed changes

[fix] Update sources

25ed104

Shnoulle closed this Jun 19, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Develop NOT for production #26

Develop NOT for production #26

Shnoulle commented Feb 20, 2017

Shnoulle Feb 20, 2017

zamentur Apr 1, 2017

Shnoulle Apr 1, 2017

Shnoulle Feb 20, 2017

Shnoulle Feb 20, 2017

zamentur Apr 1, 2017

Shnoulle Apr 1, 2017

Shnoulle Feb 20, 2017

Shnoulle Feb 20, 2017

Shnoulle Feb 20, 2017

Shnoulle Feb 20, 2017

Shnoulle commented Apr 1, 2017

zamentur left a comment

zamentur Apr 1, 2017

Shnoulle Apr 1, 2017

zamentur Apr 1, 2017

Shnoulle Apr 1, 2017

zamentur Apr 1, 2017

zamentur commented Apr 1, 2017

Shnoulle commented Apr 1, 2017 •

edited

Loading

Shnoulle commented Apr 29, 2017

Shnoulle commented Jun 3, 2017

Shnoulle commented Jun 19, 2017

		# Apply patches
		if [ -f ${PKG_DIR}/patches/$SOURCE_ID-*.patch ]; then


		sudo yunohost app addaccess $app -u $admin
		ynh_sso_access "/index.php?r=admin,/index.php?r=plugins,/scripts"

Develop NOT for production #26

Develop NOT for production #26

Conversation

Shnoulle commented Feb 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Shnoulle commented Apr 1, 2017

zamentur left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zamentur commented Apr 1, 2017

Shnoulle commented Apr 1, 2017 • edited Loading

Shnoulle commented Apr 29, 2017

Shnoulle commented Jun 3, 2017

Shnoulle commented Jun 19, 2017

Shnoulle commented Apr 1, 2017 •

edited

Loading