-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for custom data directory #407
base: testing
Are you sure you want to change the base?
Conversation
!testme |
Probably fixes the issue I had: #485 👍 |
!testme |
Hello. Any news on this PR? |
!testme |
!testme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm we gotta be careful with this, this is gonna create weird behavior in packaging v2 context. For example the behavior of the --purge option of yunohost app remove
is coupled to the data_dir
setting. So one way or another, the value of the setting should be synced with the value of the conf file
It's still not clear to me what's the recommended way of having a custom data location (for this app or others) between changing the app's data_dir setting, or using mount bind, or other things. I would tend to think that a mount bind is a far better option though
Problem
I configured my nextcloud with custom data directory and upgrade failed due to hardcoded data directory.
Solution
Instead of using hardcoded path, I look for the data directory in the config file of nextcloud.
PR Status
Validation
Minor decision
Package_check results