Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for custom data directory #407

Open
wants to merge 10 commits into
base: testing
Choose a base branch
from

Conversation

oiseauroch
Copy link

@oiseauroch oiseauroch commented May 14, 2021

Problem

I configured my nextcloud with custom data directory and upgrade failed due to hardcoded data directory.

Solution

Instead of using hardcoded path, I look for the data directory in the config file of nextcloud.

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation


Minor decision

  • Upgrade previous version :
  • Code review :
  • Approval (LGTM) :
  • Approval (LGTM) :

Package_check results


  • An automatic package_check will be launch at https://ci-apps-dev.yunohost.org/, when you add a specific comment to your Pull Request: "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!"*

@oiseauroch
Copy link
Author

!testme

@yunohost-bot
Copy link
Contributor

😜
Test Badge

@MayeulC
Copy link
Contributor

MayeulC commented Apr 29, 2022

Probably fixes the issue I had: #485 👍

@ericgaspar ericgaspar deleted the branch YunoHost-Apps:testing July 3, 2022 09:32
@ericgaspar ericgaspar closed this Jul 3, 2022
@ericgaspar ericgaspar reopened this Jul 3, 2022
@ericgaspar
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

Fingers crossed!
Test Badge

@artybdrlt
Copy link

Hello. Any news on this PR?

@ericgaspar
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

Fingers crossed!
Test Badge

@ericgaspar
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

✌️
Test Badge

Copy link
Member

@alexAubin alexAubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm we gotta be careful with this, this is gonna create weird behavior in packaging v2 context. For example the behavior of the --purge option of yunohost app remove is coupled to the data_dir setting. So one way or another, the value of the setting should be synced with the value of the conf file

It's still not clear to me what's the recommended way of having a custom data location (for this app or others) between changing the app's data_dir setting, or using mount bind, or other things. I would tend to think that a mount bind is a far better option though

@ericgaspar ericgaspar deleted the branch YunoHost-Apps:testing August 12, 2023 13:42
@ericgaspar ericgaspar closed this Aug 12, 2023
@ericgaspar ericgaspar reopened this Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants