Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextcloud parameters in config panel #638

Open
wants to merge 16 commits into
base: testing
Choose a base branch
from
Open

Conversation

zamentur
Copy link
Contributor

Problem

Some configuration parameters need to be adapt according to localization, kind of network, security models, ldap or internal nextcloud account, disk space available, cpu, etc.

Solution

Add some parameters to the config panel

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@zamentur zamentur changed the base branch from master to testing December 10, 2023 01:07
@zamentur
Copy link
Contributor Author

I hesitate between categories defines in this PR (modes, localization, account, files, apps, php_fpm) and another way to organize things (main, customization, resources, performances, security)

@zamentur
Copy link
Contributor Author

Preview

ynh local_yunohost_admin_

Security Tabs ?

I wonder if a security tabs with those options should exists:

security
    Account
        TODO [sec][advanced] auto_logout
        TODO [sec][advanced] remember_login_cookie_lifetime
        TODO [sec][advanced] token_auth_enforced
        TODO [sec][advanced] allow_user_to_change_display_name

    Files
        TODO config_is_read_only
        TODO allowsymlinks
        TODO [sec] sharing.maxAutocompleteResults' => 25,
    
    Internet connectivity
        TODO allow_local_remote_servers (onlyoffice bug)
        TODO lookup_server
        TODO connectivity_check_domains

Potential TODO

  • Manage upgrade of config.php files
  • 'forbidden_chars' => array('?', '<', '>', ':', '*', '|', '"', chr(0), "\n", "\r")
  • Think about log stuff
  • Add a rescan action ? Is it still needed ?

@zamentur zamentur marked this pull request as ready for review December 11, 2023 03:02
@zamentur
Copy link
Contributor Author

!testme

@yunohost-bot
Copy link
Contributor

✌️
Test Badge

config_panel.toml Outdated Show resolved Hide resolved
config_panel.toml Outdated Show resolved Hide resolved
scripts/install Outdated Show resolved Hide resolved
scripts/install Outdated Show resolved Hide resolved
conf/config.json Outdated Show resolved Hide resolved
@ericgaspar
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

Alrighty!
Test Badge

@alexAubin
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

Meow 🐈
Test Badge

alexAubin and others added 6 commits January 21, 2024 16:57
…ade if it doesnt exist, making config panel crash when upgrading from old versions ...
Co-authored-by: eric_G <46165813+ericgaspar@users.noreply.github.com>
Co-authored-by: eric_G <46165813+ericgaspar@users.noreply.github.com>
Co-authored-by: eric_G <46165813+ericgaspar@users.noreply.github.com>
Co-authored-by: eric_G <46165813+ericgaspar@users.noreply.github.com>
Co-authored-by: eric_G <46165813+ericgaspar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants