Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage oldstable version #714

Open
wants to merge 98 commits into
base: testing
Choose a base branch
from
Open

Manage oldstable version #714

wants to merge 98 commits into from

Conversation

kay0u
Copy link
Member

@kay0u kay0u commented Aug 1, 2024

Problem

  • Description of why you made this PR

Solution

  • And how do you fix that problem

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@yunohost-bot
Copy link
Contributor

May the CI gods be with you!
Test Badge

@zamentur
Copy link
Contributor

!gogogadgetoci

@yunohost-bot
Copy link
Contributor

Meow 🐈
Test Badge

@kay0u
Copy link
Member Author

kay0u commented Aug 23, 2024

!testme

@yunohost-bot
Copy link
Contributor

📖
Test Badge

@yunohost-bot
Copy link
Contributor

✌️
Test Badge

@zamentur zamentur changed the title WIP: Manage oldstable version Manage oldstable version Aug 23, 2024
kay0u and others added 14 commits August 27, 2024 14:52
* add notify_push option

* self-test notify_push

* fix notify_app

* new permission hpb, some fixes

* fix the restore script

* fix restore²

* fix upgrade

* fix socket path

* Update doc/DISCLAIMER_fr.md

* split nginx conf

* use official helpers with modified args

* Auto-update READMEs

* update nginx conf, add new services

* add tests

* add arch var

* tests: enable_notify_push is false by default

* fix upgrade

* final_path -> install_dir

* fix socket nginx path

* add notify_push nginx conf before, so the reload in ynh_add_nginx_config load it

* fully functional version

* readd a removed fix

* run cron task after notify push setup

* Auto-update READMEs

* remove systemd files

* add notify push in config panel

* add cron again because to make notify push happy

* fix indent

* enable/disable the notify push path

* fix path unit

* exec only for nextcloud user

* move sock file to /var/run

* start notify-push after the watcher

* ²

* remove warning

* cron can sometimes fail when the database is not fully initialized, retries the cron job several times and catch catch the error on failure

* oupsie

* Apply suggestions from code review

Co-authored-by: eric_G <46165813+ericgaspar@users.noreply.github.com>

---------

Co-authored-by: Éric Gaspar <46165813+ericgaspar@users.noreply.github.com>
Co-authored-by: yunohost-bot <yunohost@yunohost.org>
Fix removing ACL permissions on uninstall
@zamentur
Copy link
Contributor

!testme

@yunohost-bot
Copy link
Contributor

🌻
Test Badge

@yunohost-bot
Copy link
Contributor

📚 🐛
Test Badge

Copy link
Contributor

@zamentur zamentur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants