Do not backup image cache - Implement Backup core only #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!testme |
|
Fingers crossed! |
|
I don't really know how to exclude this folder from the backup… If Yunohost backup helper (https://yunohost.org/en/packaging_apps_helpers#ynh-backup) had an option for that it would be better 😅 I'm not happy with the current solution... if /tmp is not in the same partition it can be a real trouble. |
|
CI is not working right now. |
|
CI fails because the directory does not exist… I need to had a condition. |
|
No time to work on this right now, help appreciated :) |
Salamandar
force-pushed
the
exclude-image-cache-from-backup
branch
from
aa1efad
to
5421d05
Compare
|
rebased. |
|
!testme |
|
🎠 |
Salamandar
force-pushed
the
exclude-image-cache-from-backup
branch
from
5421d05
to
65d4ee5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you choose to download articles images in your Wallabag, this "cache" is taking a lot of space.
Users might want to backup everything but these images (as your can "download" them again later) to save space.
Solution
Implement BACKUP_CORE_ONLY : in that case the image cache is not saved.
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)