-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provision: reload the firewall only once #1846
Open
OniriCorpe
wants to merge
6
commits into
dev
Choose a base branch
from
provision-reload-firewall-once
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16e6d99
to
dbeae78
Compare
dbeae78
to
832b9d3
Compare
d70f5ac
to
6b564ef
Compare
455456b
to
b8b683b
Compare
Salamandar
approved these changes
May 21, 2024
alexAubin
reviewed
May 22, 2024
logger.warning( | ||
m18n.n("port_already_closed", port=port, ip_version=ipv) | ||
) | ||
logger.warning(m18n.n("port_already_closed", port=port, ip_version=ipv)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh actually we probably want to have an option to disable this warning, otherwise everytime a port is not to be "exposed" (= the vast majority of the apps ?), yunohost will display a warning during install/upgrade/... when provision ports
Similar stuff for port_already_open
too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
for now, during the provisionning/deprovisionning, the firewall is reloaded for each added or removed port
for example:
Solution
check if the port list has changed at the end of the port provisionning/deprovisionning, and if so: reload the firewall
PR Status
done
How to test
do a port provisionning/deprovisionning
not tested tho