-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deny PRs where shfmt doesn't pass #1941
Conversation
e9283f6
to
c5002a1
Compare
Ready for review |
So with the new helpers you can do:
The last option, act, will setup something that's really close to a Github CI runner and run the actual tests through docker. That's the entire concept and power of act and it's great! The first 3 options require that I think that's already quite a few options and i'm happy to document them. Feedback is welcome. |
c54afcb
to
8f4ffab
Compare
Thank you @selfhoster1312 <3 For the rest of your commits I pushed the |
Hopefully this should fail as the scripts don't pass. This is just an initial attempt i haven't checked that the CI syntax is good... Wait for it ! :)
EDIT: All is good now and it was successfully applied.