Skip to content

Commit

Permalink
add code notes
Browse files Browse the repository at this point in the history
  • Loading branch information
Yunuuuu committed Mar 14, 2024
1 parent 6256645 commit 3d343b6
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 0 deletions.
16 changes: 16 additions & 0 deletions R/Class-Delayed.R
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,22 @@ delayedop_call_BPCells_method <- function(..., before = NULL, after = NULL, Arra
}

### - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
# https://developer.r-project.org/howMethodsWork.pdf
# The current implementation (as of version 2.4.0 of R) works as follows. The
# individual distances, as explained in section 3, are the number of steps in
# the path of superclasses between the target and the defined class, with the
# distance to "ANY" larger than any other distance. If several arguments are
# involved, the distances for each argument are added and the total distance is
# used to compare candidate methods. In the case of ties, the first of the
# candidates is chosen. Because the candidate signatures are effectively an
# outer product of the individual superclass lists, and because of the way those
# lists are created, the effect is to select the first possible method in an
# ordering by the order of superclasses in the "contains" slot of the class
# definition, ordering first according to the first argument in the signature,
# then the second, etc
# So we should always put BPCellsDelayedOp Class in the first super-class of
# other extended DelayedOp object.

#' BPCellsDelayedOp objects
#'
#' Provide a parallel [DelayedOp][DelayedArray::DelayedOp] object
Expand Down
1 change: 1 addition & 0 deletions R/Method-BindMatrix.R
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ mould_BPCells("BPCellsDelayedAbind", "ColBindMatrices",
contains = c("BPCellsDelayedOp", "DelayedAbind")
)

# methods::showMethods("is_noop", where = asNamespace("DelayedArray"))
#' @importFrom DelayedArray is_noop
#' @export
#' @rdname BPCellsDelayedOp-class
Expand Down

0 comments on commit 3d343b6

Please sign in to comment.