Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update member group #99

Merged
merged 5 commits into from
Sep 10, 2021
Merged

Update member group #99

merged 5 commits into from
Sep 10, 2021

Conversation

YunzheZJU
Copy link
Owner

@YunzheZJU YunzheZJU commented Sep 6, 2021

This PR implements the alternative described in #97.

  • Rename member group 'Others' to 'New Debuts' and move group members into relative groups.
  • Hide empty member groups.

0
1

Comment on lines 16 to 26
// Each key in 'groups' is a group defined at https://www.hololive.tv/member and the according value is the localized name of it
groups: {
// This group collects the members who are newly tracked by the backend but have not been updated yet in this extension
newDebuts: "Neue Debüts!",
hololive: "Hololive",
holostars: "Holostars",
inonakaMusic: "INoNaKa MUSIC",
hololiveChina: "Hololive China",
hololiveIndonesia: "Hololive Indonesia",
hololiveEnglish: "Hololive English",
others: "Andere"
hololiveEnglish: "Hololive English"
}
Copy link
Owner Author

@YunzheZJU YunzheZJU Sep 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Group 'Others' is renamed to 'New Debuts!'.

I used Google Translation to translate the word 'New Debuts' into German and Japanese but I am not sure if this expression is weird among native speakers. For example, is it better to use 'Recent' than 'New', or better to use 'joined'/'added' than 'debut' according to native language preferences?

Would you please spare some time and take a look on these translations? @samdotxml @is984 @ReiRokusanami0010 @taizan-hokuto (Since you have contributed to this project recently.)

I will leave this PR open for at least 48 hours. Feel free to ignore me if you are busy or there is no problem. Thank you!

Copy link
Contributor

@is984 is984 Sep 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment for Translation of Japanese

In this case, I think it's more like "recently debuted member".
If you want to label the group as such, you can use "新規メンバー" , "新メンバー","新規デビュー",etc.
There is also the expression "最近デビューしたメンバー," although it is a bit longer.
There are so many different expressions that even Japanese people have a hard time judging them.
In my opinion, "新メンバー" is more appropriate, but it is difficult to say for sure because of the reader's preference.
I'm sorry I don't have a clear answer for you.

Note: The phrase "~の (meaning: of)" is rarely used as a proper noun for a group.
@YunzheZJU

Copy link
Owner Author

@YunzheZJU YunzheZJU Sep 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment for Translation of Japanese

In this case, I think it's more like "recently debuted member".
If you want to label the group as such, you can use "新規メンバー" , "新メンバー","新規デビュー",etc.
There is also the expression "最近デビューしたメンバー," although it is a bit longer.
There are so many different expressions that even Japanese people have a hard time judging them.
In my opinion, "新メンバー" is more appropriate, but it is difficult to say for sure because of the reader's preference.
I'm sorry I don't have a clear answer for you.

Note: The phrase "~の (meaning: of)" is rarely used as a proper noun for a group.
@YunzheZJU

Yes, you are right. I am meaning "recently debuted member" here.

Your suggestion is useful! I will take them into consideration.

For me, I am interested in 新規デビュー and 新メンバー. They are both short and meaningful.

You've provided so much information. Thank you!

@YunzheZJU YunzheZJU merged commit 96c19a2 into master Sep 10, 2021
@YunzheZJU YunzheZJU deleted the update-member-group branch September 10, 2021 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants