Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: infinity-loop in @Published property #195

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

YusukeHosonuma
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2022

Codecov Report

Merging #195 (3cb344c) into main (e35e9b4) will decrease coverage by 1.10%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   76.41%   75.31%   -1.11%     
==========================================
  Files          13       13              
  Lines         687      713      +26     
==========================================
+ Hits          525      537      +12     
- Misses        162      176      +14     
Impacted Files Coverage Δ
Sources/Core/PrettyDescriber.swift 68.56% <40.00%> (-2.17%) ⬇️
Sources/Public/Pretty.swift 96.29% <0.00%> (+0.09%) ⬆️
Sources/Core/Color/ColorTheme.swift 73.68% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e35e9b4...3cb344c. Read the comment docs.

@YusukeHosonuma YusukeHosonuma marked this pull request as ready for review June 19, 2022 05:15
@YusukeHosonuma YusukeHosonuma changed the title hotfix: infinity-loop in @Published property hotfix: infinity-loop in @Published property Jun 19, 2022
Copy link
Collaborator

@sahara-ooga sahara-ooga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YusukeHosonuma YusukeHosonuma merged commit 5bc8648 into main Jun 20, 2022
@YusukeHosonuma YusukeHosonuma deleted the hotfix-infinity-loop branch June 20, 2022 00:07
@sahara-ooga sahara-ooga added this to the v1.4.1 milestone Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants