Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

フリーテストの追加をmainブランチにマージ #95

Merged
merged 2 commits into from
Jan 1, 2024
Merged

フリーテストの追加をmainブランチにマージ #95

merged 2 commits into from
Jan 1, 2024

Conversation

YuukiToriyama
Copy link
Owner

@YuukiToriyama YuukiToriyama commented Jan 1, 2024 •
edited
Loading

変更点

  • 以下のような形式でIssueにコメントをすると、入力した住所がパースできるかどうかを簡易的に確認できるようにした
```text:freetest
東京都世田谷区世田谷4丁目21番27号
東京都世田谷区世田谷4-21-27
```

課題

  • Rust側でpanicを起こした時、JavaScript側でtry/catchしてもエラーハンドリングできないので、テストが強制的に終了してしまう

@YuukiToriyama YuukiToriyama self-assigned this Jan 1, 2024
@YuukiToriyama YuukiToriyama added the enhancement New feature or request label Jan 1, 2024
@YuukiToriyama
Copy link
Owner Author 

東京都世田谷区世田谷4丁目21番27号
東京都世田谷区世田谷4-21-27

@YuukiToriyama YuukiToriyama merged commit 01781eb into main Jan 1, 2024
1 check passed
@YuukiToriyama YuukiToriyama deleted the feature/enable-free-test branch May 16, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@YuukiToriyama YuukiToriyama

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@YuukiToriyama