Fix Android CI CMake Java JNI error #6284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying
CMAKE_ANDROID_API
is apparently more correct than specifyingCMAKE_SYSTEM_VERSION
on CMake 3.24 (and earlier versions). Reference is here https://cmake.org/cmake/help/v3.24/manual/cmake-toolchains.7.html#cross-compiling-for-android-with-the-ndk where it describes theCMAKE_SYSTEM_VERSION
variable:Passing CI is here for a commit that enabled CI on my branch for these changes https://github.com/ekilmer/z3/actions/runs/2890880110