-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use noexcept
more.
#7058
Use noexcept
more.
#7058
Conversation
@@ -45,7 +45,7 @@ class f2n { | |||
m_manager.set(m_one, ebits, sbits, 1); | |||
} | |||
|
|||
f2n(f2n && other) : m_manager(other.m_manager), m_mode(other.m_mode), m_ebits(other.m_ebits), m_sbits(other.m_sbits), | |||
f2n(f2n && other) noexcept : m_manager(other.m_manager), m_mode(other.m_mode), m_ebits(other.m_ebits), m_sbits(other.m_sbits), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one can go too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this one goes away, there's a build error on Ubuntu in CI. I've added it back for now.
FWIW, in the long run these swaps should go. They are reminiscent of pre-C++11 code. We now have std::move, so most of these swaps are useless. |
This applies it to swap functions as well as move constructors, move assignment, etc.
6c6fddd
to
e978364
Compare
Updated, rebased to fix a merge conflict, and force pushed. |
This removes them for case/body expansion. Suggested by @nunoplopes.
e978364
to
7d7624f
Compare
This applies it to swap functions as well as move constructors, move assignment, etc.