Migrate string_buffer to use C++ smart pointer. #7351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
string_buffer class is now migrated to use smart pointers instead of manually allocated and deallocated memory. The `buffer` function decides and returns if the buffer is currently using initial buffer or the allocated buffer.
|
alloc/dealloc use memory_manager. STL allows associating custom allocators with classes that call new/delete. |
To decide whether `m_aig_manager` should be a `std::unique_ptr`, `std::shared_ptr`, or `std::weak_ptr`, let's analyze the ownership semantics and usage pattern of `m_aig_manager` in the `aig_tactic` class. Analysis of Ownership: 1. **Single Ownership**: - `m_aig_manager` is allocated within the `mk_aig_manager` struct's constructor, where it calls `alloc(aig_manager, ...)`, and deallocated within the `mk_aig_manager` destructor using `dealloc(m_owner.m_aig_manager);`. - `m_aig_manager` is not shared or referenced by any other part of the code outside of `aig_tactic` and `mk_aig_manager`. This suggests that `aig_manager` is owned exclusively by the `aig_tactic` class. 2. **Lifespan Management**: - `m_aig_manager` is created within `mk_aig_manager` and is automatically destroyed when `mk_aig_manager` goes out of scope (which happens after the tactic is applied). - This indicates that `m_aig_manager`'s lifespan is tightly coupled with the `aig_tactic` class or its method execution. 3. **No Sharing Needed**: - There is no indication that `m_aig_manager` needs to be shared across multiple owners or instances. Therefore, there’s no need for `std::shared_ptr`. - Since there’s no sharing, `std::weak_ptr` is also unnecessary. Conclusion: Given the analysis, **`std::unique_ptr`** is the most appropriate choice for managing `m_aig_manager`. It ensures that the memory is properly managed (automatically deleted when the pointer goes out of scope), and it enforces the exclusive ownership semantics that are currently implied by the code.
|
Plus the changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
string_bufferclass is now migrated to use smart pointers instead of manually allocated and deallocated memory.The
bufferfunction decides and returns if the buffer is currently using initial buffer or the allocated buffer.tst_small_buffer_expandto test memory expansion of the small buffer, i.e., the test forces the buffer to go fromm_initial_bufferto dynamically allocatedm_buffer.