Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getLabel() and getPluralLabel() deprecation #113

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Fix getLabel() and getPluralLabel() deprecation #113

merged 1 commit into from
Nov 23, 2023

Conversation

devhoussam1998
Copy link
Contributor

@devhoussam1998 devhoussam1998 commented Nov 22, 2023 •
edited
Loading

closes #112

@what-the-diff What The Diff
Copy link

what-the-diff bot commented Nov 22, 2023

PR Summary

  • Modification of PageResource.php
    The names of two methods in the PageResource.php file were updated for better clarity.
    • The getLabel method is now called getModelLabel.
    • The getPluralLabel method is now referred to as getPluralModelLabel.

The changes in this pull request help make our code more intuitive, with straightforward method names, making it easier for team members to understand the purpose of these methods.

@Z3d0X Z3d0X merged commit 280d6dc into Z3d0X:2.x Nov 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PageResource fix deprecation
2 participants
@devhoussam1998 @Z3d0X