Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix octane issues change registering package from scoped to singleton #130

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Fix octane issues change registering package from scoped to singleton #130

merged 1 commit into from
Jan 20, 2024

Conversation

ksimenic
Copy link
Contributor

This PR resolves octane issues discussed in #120

@what-the-diff What The Diff
Copy link

what-the-diff bot commented Jan 19, 2024

PR Summary

  • Transitioned Service Registration Method
    The way the 'filament-fabricator' service is registered within the FilamentFabricatorServiceProvider.php file has been altered. Initially, it employed the scoped method, but it has now been switched to the singleton method. This means that only a single instance of the service will be created and then reused, instead of creating new instances every time; enhancing performance and reducing memory usage.

@Z3d0X Z3d0X merged commit 06ecfe5 into Z3d0X:2.x Jan 20, 2024
3 checks passed
@Z3d0X Z3d0X mentioned this pull request Feb 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksimenic @Z3d0X