Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable Database Table & Migration Down Method #19

Merged
merged 3 commits into from
Jan 7, 2023
Merged

Configurable Database Table & Migration Down Method #19

merged 3 commits into from
Jan 7, 2023

Conversation

mrlinnth
Copy link
Contributor

@mrlinnth mrlinnth commented Nov 2, 2022

No description provided.

@mrlinnth
Copy link
Contributor Author

mrlinnth commented Nov 2, 2022

@Z3d0X faced an issue when I rollback my migration since it is missing down().

I would like to discuss and confirm the following enhancement with you.

  • add new config 'page-table-name' => 'pages'
  • use above config in migration and model
    If you agreed, I can create another PR for it.

@Z3d0X
Copy link
Owner

Z3d0X commented Nov 10, 2022 

* add new config `'page-table-name'  => 'pages'`

* use above config in migration and model
  If you agreed, I can create another PR for it.

Okay. You can continue your work on this PR

@Z3d0X Z3d0X marked this pull request as draft November 10, 2022 09:28
@mrlinnth mrlinnth marked this pull request as ready for review November 15, 2022 08:33
@mrlinnth
Copy link
Contributor Author

@Z3d0X sorry for the delay. I have updated and pushed.

@Z3d0X Z3d0X changed the title Update migration with down method Configurable Database Table & Migration Down Method Jan 7, 2023
@Z3d0X Z3d0X merged commit 5a28a48 into Z3d0X:main Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrlinnth @Z3d0X