Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Routing Urls #47

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Fix Routing Urls #47

merged 2 commits into from
Feb 27, 2023

Conversation

Z3d0X
Copy link
Owner

@Z3d0X Z3d0X commented Feb 27, 2023

  • Fix route prefixing
  • Fix inconsistent routing
  • Restrict slugs starting/ending with slashes(/) (except homepage)

@what-the-diff
Copy link

what-the-diff bot commented Feb 27, 2023

  • Added a new validation rule to the slug field.
  • Fixed some issues with routing prefixes and page URLs in various places of the package codebase, including:
    • The FilamentFabricator::getRoutingPrefix() method now returns an empty string instead of null if no custom routing prefix is set (this fixes an issue where pages would not be accessible when using Laravel's default route model binding).
    • Page URL values are always prefixed with a slash character ('/') for consistency reasons. This also makes it possible to use relative paths as slugs without having them being treated as absolute ones by Filament Fabricator itself or other parts of your application that might rely on this behavior (e.g., Nova's resource actions).

@Z3d0X Z3d0X merged commit 165c387 into main Feb 27, 2023
@Z3d0X Z3d0X deleted the bugfix/fix-routing-urls branch March 30, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant