Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/update azure certbot #110

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Task/update azure certbot #110

merged 3 commits into from
Apr 11, 2024

Conversation

felixZdi
Copy link
Collaborator

Creating as draft - update for lib required as soon as release is available

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

File Coverage
All files 41% ✅
___init___.py 0% ❌
certbot_manager.py 42% ✅
client.py 0% ❌
dns_delegation.py 14% ❌
key_vault_manager.py 64% ✅
os_manager.py 60% ✅
config/__init__.py 55% ✅
context/__init__.py 37% ❌

Minimum allowed coverage is 40%

Generated by 🐒 cobertura-action against 3730a1f

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024 •
edited
Loading

Test Results

19 tests  ±0   19 ✅ ±0   2s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 3730a1f. ± Comparison against base commit 9ff20a8.

♻️ This comment has been updated with latest results.

@felixZdi felixZdi marked this pull request as ready for review April 8, 2024 12:57
@felixZdi felixZdi added the patch Patch release label Apr 8, 2024
rembik
rembik approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@rembik rembik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixZdi felixZdi merged commit 3d37e13 into main Apr 11, 2024
8 checks passed
@felixZdi felixZdi deleted the task/update-azure-certbot branch April 11, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rembik rembik rembik approved these changes

Assignees
No one assigned
Labels
patch Patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixZdi @rembik