-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add support for all types of azure auth mechanism #126
Merged
felixZdi
merged 15 commits into
ZEISS:main
from
Selvas666:feature/Add-support-for-all-types-of-Azure-auth-mechanism
Jul 10, 2024
Merged
Feature/add support for all types of azure auth mechanism #126
felixZdi
merged 15 commits into
ZEISS:main
from
Selvas666:feature/Add-support-for-all-types-of-Azure-auth-mechanism
Jul 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixZdi
reviewed
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Especially the testing and backwards compatibility!
…rove tests and refactor credentials validator logic
Co-authored-by: felixZdi <93919627+felixZdi@users.noreply.github.com>
felixZdi
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO Technical Task ID: 785124
Added supprot for all types of authentication as supported by certbot-dns-azure plugin.
https://docs.certbot-dns-azure.co.uk/en/latest/index.html#certbot-azure-workload-identity-ini