Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Codecov token with secret #100

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

FelixS90
Copy link
Collaborator

@FelixS90 FelixS90 commented Jun 3, 2024

Description

Replace Codecov token with secret configured on repo level
Old secret regenerated
Relevant motivation: security
Dependencies required for this change: None except outlined above

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

PR

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of libCZI following Versioning of libCZI depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@FelixS90 FelixS90 added the cla Contributor License Agreement sent to Admin label Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.99%. Comparing base (0c4f6c7) to head (b70cf9a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   65.99%   65.99%           
=======================================
  Files          85       85           
  Lines       10653    10653           
=======================================
  Hits         7030     7030           
  Misses       3623     3623           
Flag Coverage Δ
windows-latest 65.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FelixS90 FelixS90 marked this pull request as ready for review June 5, 2024 13:24
Copy link
Contributor

@DaveyJonesBitPail DaveyJonesBitPail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@DaveyJonesBitPail DaveyJonesBitPail merged commit 067f3b0 into main Jun 5, 2024
15 of 16 checks passed
@ptahmose ptahmose deleted the FelixS90-patch-1 branch June 6, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants