Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for "visiblity optimization" #80

Merged
merged 14 commits into from
Nov 21, 2023

Conversation

ptahmose
Copy link
Contributor

Description

This is fixing a bug with the "non-visible-tile-optimization" introduced with #78.
A unit-test ensuring proper operation of this case was added.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

locally and unit-test added

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of libCZI following Versioning of libCZI depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@ptahmose ptahmose requested review from a team and DaveyJonesBitPail November 21, 2023 10:58
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6497366) 65.11% compared to head (784cc8f) 65.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   65.11%   65.11%           
=======================================
  Files          81       81           
  Lines       10470    10470           
=======================================
  Hits         6818     6818           
  Misses       3652     3652           
Flag Coverage Δ
windows-latest 65.11% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptahmose ptahmose added the cla Contributor License Agreement sent to Admin label Nov 21, 2023
@ptahmose ptahmose merged commit 8cd30f6 into ZEISS:main Nov 21, 2023
15 of 16 checks passed
@ptahmose ptahmose deleted the jbl/bugfix_visiblity_optimization branch November 21, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants