-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add codespaces-configuration #87
Conversation
Signed-off-by: ptahmose <jbohl@h-quer.de>
Signed-off-by: ptahmose <jbohl@h-quer.de>
Signed-off-by: ptahmose <jbohl@h-quer.de>
Signed-off-by: ptahmose <jbohl@h-quer.de>
Signed-off-by: ptahmose <jbohl@h-quer.de>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
=======================================
Coverage 65.38% 65.38%
=======================================
Files 83 83
Lines 10621 10621
=======================================
Hits 6945 6945
Misses 3676 3676
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Adding a .devcontainer file would imply to encourage the use of a docker container fo VS code. So I would have expected an adaption in the "how-to-build" documentation. Now we are one step from building (and maintaining) containers for building (locally and in pipelines)... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I did not try and only had a coarse look, my suggestion is to wait at least for one other review.
Please see my comment on the build documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good. We may want to add some extra extensions / features in the future (like cmantic or clangd) but everything that is installed in the base image should work pretty well.
Description
Adding a .devcontainer folder with some default configuration. This should allow to build libCZI (including CZICmd and with libcurl-support) right from the start (depending on #86).
The only modifications of the boilerplate code (c.f. here) we made are:
Type of change
How Has This Been Tested?
Checklist: