-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export "list of propbag parameters" for streams-property-bag #92
Merged
ptahmose
merged 20 commits into
ZEISS:main
from
ptahmose:jbl/export_streams_propbag_parameters
Jan 8, 2024
Merged
export "list of propbag parameters" for streams-property-bag #92
ptahmose
merged 20 commits into
ZEISS:main
from
ptahmose:jbl/export_streams_propbag_parameters
Jan 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
+ Coverage 65.38% 65.39% +0.01%
==========================================
Files 84 84
Lines 10645 10650 +5
==========================================
+ Hits 6960 6965 +5
Misses 3685 3685
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ReneBoeckelmann
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems beneficial to have a complete list of available parameters (for the property-bag for initializing stream-objects) being exported by libCZI - this should allow for client code which does not have to be updated with every change in this list.
The new functionality is then leveraged in the parser in CZICmd.
Type of change
How Has This Been Tested?
Describe the tests that you ran to verify your changes.
Provide instructions to reproduce.
Checklist: