Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export "list of propbag parameters" for streams-property-bag #92

Merged
merged 20 commits into from
Jan 8, 2024

Conversation

ptahmose
Copy link
Contributor

Description

It seems beneficial to have a complete list of available parameters (for the property-bag for initializing stream-objects) being exported by libCZI - this should allow for client code which does not have to be updated with every change in this list.
The new functionality is then leveraged in the parser in CZICmd.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Describe the tests that you ran to verify your changes.
Provide instructions to reproduce.

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of libCZI following Versioning of libCZI depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@ptahmose ptahmose marked this pull request as ready for review December 31, 2023 01:09
@ptahmose ptahmose added the cla Contributor License Agreement sent to Admin label Dec 31, 2023
Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5bca15f) 65.38% compared to head (82d990e) 65.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   65.38%   65.39%   +0.01%     
==========================================
  Files          84       84              
  Lines       10645    10650       +5     
==========================================
+ Hits         6960     6965       +5     
  Misses       3685     3685              
Flag Coverage Δ
windows-latest 65.39% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptahmose ptahmose merged commit 5e5a1fc into ZEISS:main Jan 8, 2024
15 checks passed
@ptahmose ptahmose deleted the jbl/export_streams_propbag_parameters branch January 8, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants