Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unneccessary empty lines #266

Closed
weclapp-dev opened this issue Mar 22, 2022 · 2 comments
Closed

Unneccessary empty lines #266

weclapp-dev opened this issue Mar 22, 2022 · 2 comments

Comments

@weclapp-dev
Copy link
Contributor

This combination

final OutputFormat format = OutputFormat.createPrettyPrint();
format.setTrimText(false);

the XMLProviders leads to additional empty lines after each xml tag.
There are three possibilities to solve:

  1. Keep it like it is - the files are still valid
  2. Use createCompactFormat instead of createPrettyPrint and keep the formatting in the strings to build the xml
  3. Remove the formatting in building the xml tags and just let the ouputFormat do the pretty printing (favorite).
@jstaerk
Copy link
Collaborator

jstaerk commented Mar 23, 2022

Thanks for your PR, I'll have a look, probably tomorrow. Unfortunately the original reason why I disabled parts of the auto formatting (XRechnung #238) does not yet have an automatic test.

jstaerk added a commit that referenced this issue Mar 24, 2022
@jstaerk
Copy link
Collaborator

jstaerk commented Mar 24, 2022

what problems do I have it works like a charm

@jstaerk jstaerk closed this as completed Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants