Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZUGFeRDimporter does not suport UBL #435

Open
jstaerk opened this issue Aug 6, 2024 · 2 comments
Open

ZUGFeRDimporter does not suport UBL #435

jstaerk opened this issue Aug 6, 2024 · 2 comments

Comments

@jstaerk
Copy link
Collaborator

jstaerk commented Aug 6, 2024

the XPath for the getter methods like getAmount or getDueDate in ZUGFeRDimporter are written for ZF1 and ZF2 and don't yet support UBL, but in ZUGFeRDinvoiceImporter it works.

To prevent redundancy maybe one should reverse the inheritance and instead of ZUGFeRDInvoiceimporter inheriting from ZUGFeRDImporter it could be the other way around, in which case instead of writing XPath one could just return the according attributes of the parsed Invoice object.

@jstaerk
Copy link
Collaborator Author

jstaerk commented Sep 5, 2024

Most important methods

  • getIssueDate()
  • getDueDate()
  • getInvoiceId()
  • getAmount()
  • getTaxpointDate()
  • getHolder()
  • getSellerTradePartyAddress()
  • getIBAN()
  • getBIC()
  • getBankName()
  • getBuyerTradePartyName()
  • getBuyerTradePartyAddress()
  • getBuyertradePartySpecifiedTaxRegistrationID()

@jstaerk
Copy link
Collaborator Author

jstaerk commented Sep 12, 2024

tradeparty should be able to have or deliver a postaladdress?
Anyway we need to test that more thoroughly (maybe even in master, so that we can compare?), e.g. with https://github.com/ZUGFeRD/corpus/blob/master/XML-Rechnung/CII/not_validating_full_invoice_based_onTest_EeISI_300_CENfullmodel.cii.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant