Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to set uriUniversalCommunicationId on the TradeParty using JSON deserialization #456

Closed
phermsdorf opened this issue Aug 28, 2024 · 2 comments

Comments

@phermsdorf
Copy link
Contributor

Hi,

to create a valid xRechnung we need to be able to set the EMail Adress of a TradeParty. A setter would maybe look like this:

public void setUniversalCommunicationId(final String email) {
	uriUniversalCommunicationId = new SchemedID("EM", email);
}

Since we want to create the Invoice and TradeParty Objects by deserializing from JSON we need a way to set uriUniversalCommunicationId like the other values in the DeSerializationTest.java.

If you guide me a bit, i could also try to provide a pull request.
Thank you!

Bye Peter

@jstaerk
Copy link
Collaborator

jstaerk commented Sep 13, 2024

hi, did this work?

@phermsdorf
Copy link
Contributor Author

Yes, i tried to document the usage by adjusting the test case in #460 . You need to use the setEmail method which internally creates the correct SchemeID and email address.

jstaerk added a commit that referenced this issue Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants