Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test using wrong file #467

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Fix test using wrong file #467

merged 1 commit into from
Sep 20, 2024

Conversation

J-N-K
Copy link
Contributor

@J-N-K J-N-K commented Sep 9, 2024

The test writes TARGET_ATTACHMENTSPDF but validates TARGET_PDF. This fails twice:

  • on a clean build when reading the file because it does not (yet) exist
  • on subsequent builds because the file content is not the expected content

@J-N-K
Fix test using wrong file
d2959dd 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@jstaerk jstaerk merged commit d31e2d5 into ZUGFeRD:master Sep 20, 2024
@J-N-K J-N-K deleted the fixtests branch September 20, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@J-N-K @jstaerk