Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging implementation missing in CLI #472

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Conversation

J-N-K
Copy link
Contributor

@J-N-K J-N-K commented Sep 10, 2024

Fixes #434

No logging implementation was included in the shaded jar resulting in the mentioned error message and missing log outputs.

Signed-off-by: Jan N. Klug <github@klug.nrw>
@jstaerk
Copy link
Collaborator

jstaerk commented Sep 20, 2024

@phax did we remove this on purpose?

@J-N-K
Copy link
Contributor Author

J-N-K commented Sep 20, 2024

It was never added. When switching from java.util-logging to slf4j you need to include the api and one of several implementations. slf4j-simple is quite common for standalone-cli-applications (it outputs to System.err), but you could also choose something like log4j or logback. That might require some configuration but also allows logging to a file.

@phax
Copy link
Contributor

phax commented Sep 20, 2024

@jstaerk makes sense to me

@jstaerk jstaerk merged commit 58f99db into ZUGFeRD:master Sep 22, 2024
@J-N-K J-N-K deleted the cli-loggin branch October 6, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mustang-cli 2.12.0 warns about missing SLF4J binding; no log output in file anymore
3 participants